Re: fulltext search udf - Mailing list pgsql-general

From Tom Lane
Subject Re: fulltext search udf
Date
Msg-id 6990.1244650585@sss.pgh.pa.us
Whole thread Raw
In response to fulltext search udf  (Andreas Wenk <a.wenk@netzmeister-st-pauli.de>)
Responses Re: fulltext search udf
List pgsql-general
Andreas Wenk <a.wenk@netzmeister-st-pauli.de> writes:
>          EXECUTE 'INSERT INTO produkte
> (art_nr,bezeichnung,beschreibung,preis,steuersatz,aktionspreis,stichworte,vector)
>                  VALUES
> ('''||art_nr||''','''||bezeichnung||''','''||beschreibung||''','||preis||',
>                     '||steuersatz||','||aktionspreis||','''||stichworte||''','||vect||')';

This is not going to work with such a half-baked approach to quoting the
data values --- any value with ' or \ in it will break it.  You could
use quote_literal(), but I wonder why you are bothering with EXECUTE at
all.  If you just did the INSERT directly it would run faster and be a
lot less ugly.

            regards, tom lane

pgsql-general by date:

Previous
From: Andreas Wenk
Date:
Subject: fulltext search udf
Next
From: Pedro Doria Meunier
Date:
Subject: Re: Average connections