On 3/26/20 11:31 AM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 3/26/20 9:50 AM, Tom Lane wrote:
>>> Why is jacana doing it differently?
>> longfin is also running it (first) here
>>
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=longfin&dt=2020-03-26%2014%3A39%3A51&stg=ssl_passphrase_callback-check
> Oh, I missed that. Isn't that pretty duplicative of the
> testmodules-install phase?
Yes, but see below
>
>> I don't think this belongs in installcheck, we should add
>> 'NO_INSTALLCHECK = 1' to the Makefile.
> Why? The other src/test/modules/ modules with TAP tests do not
> specify that, with the exception of commit_ts which has a solid
> doesnt-work-in-the-default-configuration excuse.
>
>
That seems wrong, installcheck should be testing against an installed
instance, and the TAP tests don't. Moreover, from the buildfarm's POV
it's completely wrong, as we call the installcheck targets multiple
times, once for each configured locale. See one of the animals that
tests multiple locales (e.g. crake or prion)
src/test is a mess, TBH, and I have spent quite some time trying to get
it so that we test everything but without duplication, clearly without
complete success.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
