Re: Dead code in ps_status.c - Mailing list pgsql-hackers

From Michael Banck
Subject Re: Dead code in ps_status.c
Date
Msg-id 68add009.170a0220.16b3ca.d01e@mx.google.com
Whole thread Raw
In response to Re: Dead code in ps_status.c  (Michael Banck <mbanck@gmx.net>)
List pgsql-hackers
Hi,

On Tue, Aug 26, 2025 at 03:55:30PM +0200, Michael Banck wrote:
> On Thu, Feb 16, 2023 at 04:52:33PM +1300, Thomas Munro wrote:
> > Therefore I think it is safe to drop the PS_USE_PS_STRING and
> > PS_USE_CHANGE_ARGV code branches, remove a bunch of outdated comments
> > and macro tests, and prune the defunct configure/meson probe.
> 
> I noticed Postgres no longer updates the process title on the Hurd, this
> is because this was removed along other legacy platforms in this commit 
> as it was using PS_USE_PS_STRING.

By the way, on the back branches from 13-15 (before the above commit)
process title changes don't work either, presumably because __hurd__ (as
opposed to __GNU__ and __gnu_hurd__) has not been defined on GNU/Hurd
for ages (or ever?), see
https://github.com/gcc-mirror/gcc/blob/master/gcc/config/gnu.h#L25

So in case this get backpatched, I think it should be changed to
PS_USE_CLOBBER_ARGV there as well.


Michael



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Feature request: A method to configure client-side TLS ciphers for streaming replication
Next
From: Maxim Orlov
Date:
Subject: Aggregate Function corr does not always return the correct value