Re: Stats Collector Error 7.4beta1 and 7.4beta2 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Stats Collector Error 7.4beta1 and 7.4beta2
Date
Msg-id 6885.1062815179@sss.pgh.pa.us
Whole thread Raw
In response to Re: Stats Collector Error 7.4beta1 and 7.4beta2  (<andrew@dunslane.net>)
Responses Re: Stats Collector Error 7.4beta1 and 7.4beta2  (Kevin Brown <kevin@sysexperts.com>)
List pgsql-hackers
<andrew@dunslane.net> writes:
> This analysis makes sense - I think using memcmp is clearly wrong here.

Yeah, now that I think about it, we're betting on the kernel to
faithfully zero all unused bits in addrinfo structures.  In an ideal
world, all kernels would do that, but in the real world it seems like
a losing bet.

I could go for Jan's idea of putting a random key into the messages,
if anyone feels that we should not trust to the kernel to enforce the
packet source address restriction.  But the memcmp() test seems a clear
loser given today's discussions.
        regards, tom lane


pgsql-hackers by date:

Previous
From:
Date:
Subject: Re: Stats Collector Error 7.4beta1 and 7.4beta2
Next
From: Peter Eisentraut
Date:
Subject: Re: Notices for redundant operations