Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication - Mailing list pgsql-hackers

From Christian Kruse
Subject Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication
Date
Msg-id 6839735.L7AbWMpd6x@sunshine
Whole thread Raw
In response to Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Hi,

On Wednesday 12 February 2014 11:14:56 Andres Freund wrote:
> But they do take up shared memory without really needing to. I
> personally don't find that too bad, it's not much memory. If we want to
> avoid it we could have a LocalPgBackendStatus that includes the normal
> PgBackendStatus. Since pgstat_read_current_status() copies all the data
> locally, that'd be a sensible point to fill it. While that will cause a
> bit of churn, I'd guess we can use the infrastructure in the not too far
> away future for other parts.

That's a good idea. Attached you will find a patch implementing it
that way; is this how you pictured it?

Although I'm not sure if this shouldn't be done in two patches, one
for the changes needed for LocalPgBackendStatus and one for the
xid/xmin changes.

Best regards,

--
 Christian Kruse               http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


Attachment

pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Recovery inconsistencies, standby much larger than primary
Next
From: "MauMau"
Date:
Subject: Could you include bug fix for Windows ASLR issue in the next release?