Re: read-only GUC variables - supporting doc changes - Mailing list pgsql-patches

From Tom Lane
Subject Re: read-only GUC variables - supporting doc changes
Date
Msg-id 6823.1070688162@sss.pgh.pa.us
Whole thread Raw
In response to read-only GUC variables - supporting doc changes  (Joe Conway <mail@joeconway.com>)
List pgsql-patches
Joe Conway <mail@joeconway.com> writes:
> The attached is the supporting documentation for the read-only GUC
> variable changes. Comments?

Most of this paragraph strikes me as noise:

> +         Shows the size of a disk block.  It is determined by the value
> +         of <literal>BLCKSZ</> when building the server. The default
> +         value is 8192 bytes.  Each data file (heap or index) is divided
> +         into disk blocks which may be thought of as the unit of I/O.
> +         A <productname>PostgreSQL</productname> buffer contains exactly
> +         one disk block.  A <productname>PostgreSQL</productname> disk page
> +         is an abstraction layered on top of a disk block.  Specifically,
> +         while a disk block can be unformatted, a disk page is always a
> +         formatted page.  The <varname>shared_buffers</varname> setting is
> +         influenced by <varname>block_size</varname>.  See
> +         <xref linkend="runtime-config-resource"> for information.

I think you could drop the middle four sentences ("Each ... formatted page")
without losing much.

Otherwise it looks fine ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Joe Conway
Date:
Subject: read-only GUC variables - supporting doc changes
Next
From: Joe Conway
Date:
Subject: Re: [HACKERS] bytea, index and like operator again and detailed report