Re: pgsql: Refactor geometric functions and operators - Mailing list pgsql-committers

From Tomas Vondra
Subject Re: pgsql: Refactor geometric functions and operators
Date
Msg-id 681b1c97-513a-0dcd-de8a-6f6a04547d1e@2ndquadrant.com
Whole thread Raw
In response to Re: pgsql: Refactor geometric functions and operators  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers

On 07/29/2018 04:59 PM, Michael Paquier wrote:
> On Sun, Jul 29, 2018 at 12:43:29AM +0000, Tomas Vondra wrote:
>> Refactor geometric functions and operators
>>
>> The primary goal of this patch is to eliminate duplicate code and share
>> code between different geometric data types more often, to prepare the
>> ground for additional patches.  Until now the code reuse was limited,
>> probably because the simpler types (line and point) were implemented
>> after the more complex ones.
> 
> It looks that this commit has upset a couple of OSX animals, locus and
> prairiedog:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=locust&dt=2018-07-29%2013%3A13%3A35
> 
> Some AIX animals are also upset for the same reason with the handling
> of a negative sign with 0.

Yeah, the commit broke this by inadvertedly undoing 43fe90f66a0 :-(

I've posted a fix to hackers [1]. If someone with access to an affected
machine could test if it actually does the trick, that would be nice.

[1]
https://www.postgresql.org/message-id/2fce5d35-2f07-8d72-42ec-81ed97fbe640%402ndquadrant.com

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Refactor geometric functions and operators
Next
From: Michael Goldshteyn
Date:
Subject: Would like to help with documentation for Postgres 11