Re: shared-memory based stats collector - v70 - Mailing list pgsql-hackers

From Drouvot, Bertrand
Subject Re: shared-memory based stats collector - v70
Date
Msg-id 67f847bb-a1c2-f444-b2e0-333a97f1953a@amazon.com
Whole thread Raw
In response to Re: shared-memory based stats collector - v70  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Hi,

On 8/22/22 4:32 AM, Kyotaro Horiguchi wrote:
> At Wed, 10 Aug 2022 14:02:34 +0200, "Drouvot, Bertrand" <bdrouvot@amazon.com> wrote in
>> what about?
>>
>> +               /*
>> +                * Acquire the LWLock directly instead of using
>> pg_stat_lock_entry_shared()
>> +                * which requires a reference.
>> +                */
>>
>>
>> I think that's more consistent with other comments mentioning LWLock
>> acquisition.
> Sure. Thaks!. I did that in the attached.

Thank you!

The patch looks good to me.

Regards,

Bertrand




pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: use ARM intrinsics in pg_lfind32() where available
Next
From: Natarajan R
Date:
Subject: Logical replication support for generic wal record