Re: pg_recvlogical: Prevent flushed data from being re-sent after restarting replication - Mailing list pgsql-hackers

Hi,

I've made a few minor adjustments to the test patch.
The updated version is attached.

Thanks for the updated patch! Nice improvements.

Two futher proposals for the current version of the test. 

Shall we use slurp_file then everywhere we need file reads? (instead of pg_read_file)

The following can be seen as nits for your consideration. 

We can consider making the string provided in the "or die" to be consistent with the comment. We can pick one of the options below and specify the same for each.  

* receive and write the first INSERT / receive first INSERT

* establish a new connection / to reconnect

* receive and write  / receive

If we are mentioning multiple INSERTs instead of just one, might read better if we add the "s" at the end. This might be just my preference though, I leave it up to you. 

-- 
Thanks,
Mircea Cadariu