Re: Significant oversight in that #include-removal script - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Significant oversight in that #include-removal script
Date
Msg-id 6793.1231368552@sss.pgh.pa.us
Whole thread Raw
In response to Re: Significant oversight in that #include-removal script  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Significant oversight in that #include-removal script  (Bruce Momjian <bruce@momjian.us>)
Re: Significant oversight in that #include-removal script  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Bruce Momjian wrote:
>> The script certainly has no way to know it is missing an extern, and I
>> am not sure how I would even teach it that trick.

> It would be easy if the compiler were to have an option to throw a
> warning when it finds a non-static variable that doesn't have a
> corresponding extern declaration.

Yeah, I think this is hopeless (or at least not worth the cost) without
compiler support --- I was just idly wondering if newer gcc's might have
such an option.

The case at hand is actually somewhat improbable, because it requires
having a header file that exports a variable but not any of the file's
functions.  So maybe it's not worth worrying about anyway.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Do we still need constraint_exclusion?
Next
From: "D'Arcy J.M. Cain"
Date:
Subject: Re: Proposal: new border setting in psql