Re: Block-level CRC checks - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Block-level CRC checks
Date
Msg-id 6767.1226331239@sss.pgh.pa.us
Whole thread Raw
In response to Re: Block-level CRC checks  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Block-level CRC checks  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Greg Stark wrote:
>> I'm beginning to think just excluding the hint bits would be simpler and 
>> safer. If we're double buffering then it might be possible to do that 
>> pretty cheaply. Copy the whole buffer with memcpy then loop through the 
>> line pointers unsetting the hint bits. Then do the crc. Though that would 
>> prevent us from doing "zero-copy" crc by doing it in the copy.

> The downside to this idea is that we need to create a copy of the page
> and call those routines when we read the page in, too.

Ugh.  The cost on write was bad enough, but paying it on read is a lot
worse ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: per-database locale: createdb switches
Next
From: Ron Mayer
Date:
Subject: Re: Patch for ISO-8601-Interval Input and output.