Re: WIP: About CMake v2 - Mailing list pgsql-hackers

From Mark Kirkwood
Subject Re: WIP: About CMake v2
Date
Msg-id 674d4819-4453-b01a-aa7f-13215b561708@catalyst.net.nz
Whole thread Raw
In response to Re: WIP: About CMake v2  (Yury Zhuravlev <u.zhuravlev@postgrespro.ru>)
Responses Re: WIP: About CMake v2
List pgsql-hackers
On 11/11/16 08:15, Yury Zhuravlev wrote:

> Craig Ringer wrote:
>> So personally I think it'd be fine if a cmake build defaulted to
>> finding and using what it could, but offered a --minimal mode or
>> whatever that gets us just core postgres + whatever we enable
>> explicitly. But our current behaviour is OK too.
>
> To me it's best way. But I'm not sure what Tom Lane will accept this.
>
>

I just had a play with this patch - nice! (ok so it needs a fix so that 
the compile completes as mentioned prev).

I would recommend making it behave as Tom suggested. *Then* add an 
--autodetect or similar option that makes
behave in the 'finding and using what it could' manner as a 2nd patch.

regards

Mark



pgsql-hackers by date:

Previous
From: Yury Zhuravlev
Date:
Subject: Re: WIP: About CMake v2
Next
From: Tom Lane
Date:
Subject: Re: WIP: About CMake v2