Re: Offline enabling/disabling of data checksums - Mailing list pgsql-hackers

From Sergei Kornilov
Subject Re: Offline enabling/disabling of data checksums
Date
Msg-id 6744541552385215@iva8-3af116a85b74.qloud-c.yandex.net
Whole thread Raw
In response to Re: Offline enabling/disabling of data checksums  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi

> Not doing the check is a bad idea as ControlFileData should be compatible
> between the binary and the data read. I am attaching a fresh 0001
> which should be back-patched down to v11 as a bug fix.

Looks fine. We need add few words to documentation?

>>>  if (badblocks > 0)
>>>         return 1;
>>
>>  Small question: why return 1 instead of exit(1)?
>
> OK, let's fix that on the way as part of the renaming.

Was not changed?..

I have no new notes after reading updated patchset.

regards, Sergei


pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: Suggestions on message transfer among backends
Next
From: Michael Banck
Date:
Subject: Re: Offline enabling/disabling of data checksums