Re: Add Information during standby recovery conflicts - Mailing list pgsql-hackers

From Drouvot, Bertrand
Subject Re: Add Information during standby recovery conflicts
Date
Msg-id 6670629c-58de-0d51-7102-58b07dad6a9a@amazon.com
Whole thread Raw
In response to Re: Add Information during standby recovery conflicts  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi,

On 10/4/20 4:10 PM, Alvaro Herrera wrote
>> +extern const char *get_procsignal_reason_desc(ProcSignalReason reason)
>> +     {
>> +             const char *reasonDesc = "unknown reason";
>> +
>> +             switch (reason)
>> +             {
>> +                     case PROCSIG_RECOVERY_CONFLICT_BUFFERPIN:
>> +                             reasonDesc = "buffer pin";
>> +                             break;
> It doesn't work to construct sentences from pieces, for translatability
> reasons.  Maybe you can return the whole errmsg sentence from this
> routine instead.
>
Thanks for the feedback!

Enclosed a new version that take care of it.

Bertrand


Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: speed up unicode normalization quick check
Next
From: Greg Nancarrow
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)