Re: pgsql: Change Windows rename and unlink substitutes so that they time - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Change Windows rename and unlink substitutes so that they time
Date
Msg-id 6664.1168438639@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Change Windows rename and unlink substitutes so that they time  (tgl@postgresql.org (Tom Lane))
List pgsql-committers
Tatsuo Ishii <ishii@sraoss.co.jp> writes:
> Is there any reason for not back porting the fix into 8.1?

I didn't think it was adequately tested, and I'm not in a position to
test it.  (Note that a lack of 8.2 bug reports isn't a sufficient test,
since I think we whacked related code around for 8.2 --- you'd need to
actually test it in context in 8.1 ...)

>> Change Windows rename and unlink substitutes so that they time out after
>> 30 seconds instead of retrying forever.  Also modify xlog.c so that if
>> it fails to rename an old xlog segment up to a future slot, it will
>> unlink the segment instead.  Per discussion of bug #2712, in which it
>> became apparent that Windows can handle unlinking a file that's being
>> held open, but not renaming it.

            regards, tom lane

pgsql-committers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: pgsql: Change Windows rename and unlink
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Change the planner-to-executor API so that the planner tells the