Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors - Mailing list pgsql-hackers

From Marina Polyakova
Subject Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Date
Msg-id 66193a3704fe466e0ef4812302712bc8@postgrespro.ru
Whole thread Raw
In response to Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
List pgsql-hackers
> Given that the number of variables of a pgbench script is expected to
> be pretty small, I'm not sure that the sorting stuff is worth the
> effort.

I think it is a good insurance if there're many variables..

> My suggestion is really to look at both implementations and to answer
> the question "should pgbench share its variable implementation with
> psql?".
> 
> If the answer is yes, then the relevant part of the implementation
> should be moved to fe_utils, and that's it.
> 
> If the answer is no, then implement something in pgbench directly.

The structure of variables is different, the container structure of the 
variables is different, so I think that the answer is no.

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



pgsql-hackers by date:

Previous
From: Marina Polyakova
Date:
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Next
From: Chapman Flack
Date:
Subject: Re: [HACKERS] SCRAM auth and Pgpool-II