Re: partitioning and identity column - Mailing list pgsql-hackers

From Alexander Lakhin
Subject Re: partitioning and identity column
Date
Msg-id 66016eec-fe89-9a94-60dd-834054e09c91@gmail.com
Whole thread Raw
In response to Re: partitioning and identity column  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Responses Re: partitioning and identity column
List pgsql-hackers
20.02.2024 07:57, Ashutosh Bapat wrote:
>> Could you please name functions, which you suspect, for me to recheck them?
>> Perhaps we should consider fixing all of such functions, in light of
>> b0f7dd915 and d57b7cc33...
> Looks like the second commit has fixed all other places I knew except
> Identity related functions. So worth fixing identity related functions
> too. I see
> dropconstraint_internal() has two calls to check_stack_depth() back to
> back. The second one is not needed?

Yeah, that's funny. It looks like such a double protection emerged
because Alvaro protected the function (in b0f7dd915), which was waiting for
adding check_stack_depth() in the other thread (resulted in d57b7cc33).

Thank you for spending time on this!

Best regards,
Alexander



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: logical decoding and replication of sequences, take 2
Next
From: Bharath Rupireddy
Date:
Subject: Re: Improve WALRead() to suck data directly from WAL buffers when possible