Re: Suppressing occasional failures in copy2 regression test - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: Suppressing occasional failures in copy2 regression test
Date
Msg-id 65937bea0906211006y4d0ecfbawebf3d7004cd2f077@mail.gmail.com
Whole thread Raw
In response to Re: Suppressing occasional failures in copy2 regression test  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Suppressing occasional failures in copy2 regression test  (David Fetter <david@fetter.org>)
List pgsql-hackers
<div dir="ltr"><div class="gmail_quote">On Sat, Jun 20, 2009 at 2:06 AM, Alvaro Herrera <span dir="ltr"><<a
href="mailto:alvherre@commandprompt.com"target="_blank">alvherre@commandprompt.com</a>></span> wrote:<br
/><blockquoteclass="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex;
padding-left:1ex;"> About the comment in chomp: did you try to use different values of $/?<br /><font
color="#888888"><br/></font></blockquote></div><br />Well, now that I have tried it, yes, setting $/ to '\r\n' does
giveme what I expected. Both expected and result files should have the same kind of line endings though.<br /><br />I
expectedchomp() to "Do The Right Thing" and eat away '\r\n' too, not just '\n'; my mistake.<br /><br />Anyway, changing
$/in the script does not seem to be much good for our test framework. Making sure that the expected and result files
havea Unix style line endings would better stand the test of time.<br /><br />Another limitation of this script I
forgotto mention is that it barfs if the last line of the expected file is '?/unordered'. Adding it to TODO list.<br
/><br/>Best regards,<br /> -- <br />Lets call it Postgres<br /><br />EnterpriseDB      <a
href="http://www.enterprisedb.com"target="_blank">http://www.enterprisedb.com</a><br /><br
/>gurjeet[.singh]@EnterpriseDB.com<br/>singh.gurjeet@{ gmail | hotmail | indiatimes | yahoo }.com<br /> Mail sent from
myBlackLaptop device<br /></div> 

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: 8.4 open item: copy performance regression?
Next
From: Heikki Linnakangas
Date:
Subject: Re: 8.4 open item: copy performance regression?