Request a Demo
Home   >   mailing lists

Re: gistGetFakeLSN() can return incorrect LSNs - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: gistGetFakeLSN() can return incorrect LSNs
Date
Msg-id 65418A7A-9139-486A-9F67-B2F83E148E83@yandex-team.ru
Whole thread Raw
In response to gistGetFakeLSN() can return incorrect LSNs  (Andres Freund <andres@anarazel.de>)
Responses Re: gistGetFakeLSN() can return incorrect LSNs
List pgsql-hackers
Tree view 
Interesting bug. Your analysis seems correct to me.

> On 5 Mar 2026, at 22:10, Andres Freund <andres@anarazel.de> wrote:
> 
> To be safe, this code would need to use a version of GetXLogInsertRecPtr()
> that does use XLogBytePosToEndRecPtr() instead of XLogBytePosToRecPtr().

Can't we just take Insert->CurrBytePos without XLogBytePosToEndRecPtr()?
Is there a point in alignment before the page header?


Best regards, Andrey Borodin.

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Consider low startup cost in add_partial_path
Next
From: Heikki Linnakangas
Date:
Subject: Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore