Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help - Mailing list pgsql-hackers

From Michael Banck
Subject Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help
Date
Msg-id 653191ce.170a0220.f28c.09f7@mx.google.com
Whole thread Raw
In response to Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help
List pgsql-hackers
Hi,

On Thu, Oct 19, 2023 at 04:21:19PM +0300, Aleksander Alekseev wrote:
> > I believed that spread (not fast) checkpoints are the default in
> > pg_basebackup, but noticed that --help does not specify which is which -
> > contrary to the reference documentation.
> >
> > So I propose the small attached patch to clarify that.
> 
> You are right and I believe this is a good change.
> 
> Maybe we should also display the defaults for -X,
> --manifest-checksums, etc for consistency.

Hrm right, but those have multiple options and they do not enumerate
them in the help string as do -F and -c - not sure what general project
policy here is for mentioning defaults in --help, I will check some of
the other commands.


Michael



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Is this a problem in GenericXLogFinish()?
Next
From: Jelte Fennema
Date:
Subject: Re: prevent non-superuser terminate bgworker running as superuser