Re: pgarchives: Bug report + Patches: loader can't handle message in multiple lists - Mailing list pgsql-www

From Célestin Matte
Subject Re: pgarchives: Bug report + Patches: loader can't handle message in multiple lists
Date
Msg-id 652946e1-1218-bf29-705f-f5f9302128e5@cmatte.me
Whole thread Raw
In response to Re: pgarchives: Bug report + Patches: loader can't handle message in multiple lists  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pgarchives: Bug report + Patches: loader can't handle message in multiple lists  (Magnus Hagander <magnus@hagander.net>)
List pgsql-www
> How does it even get that far?  The code on line 32 of storage.py will
> check if the message is already in the archives. How does it even get
> to the point of trying to insert the message again?

Because my patch bypasses this by checking whether the message exists *in the given list*

This was the beginning of an attempt to fix a crash I had. As far as I remember, the crash was that the message already
existed.

But as said in previous email, this was not sufficient to solve the issue.

> I'm not sure I like the idea of committing after every message and
> then rolling back in the event of an error. If nothing else, this
> should be done using a savepoint instead of a complete transaction.

Attached
-- 
Célestin Matte


Attachment

pgsql-www by date:

Previous
From: Zheng Li
Date:
Subject: Wiki editor access request
Next
From: "Bobby R. Ward"
Date:
Subject: Broken slack links