Re: pg_createsubscriber TAP test wrapping makes command options hard to read. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date
Msg-id 651128.1734017715@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_createsubscriber TAP test wrapping makes command options hard to read.  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2024-12-12 Th 8:17 AM, Dagfinn Ilmari Mannsåker wrote:
>> Here's a more thorough patch, that also applies the fat comma treatment
>> to other pg_createsubscriber invocations in the same file that don't
>> currently happen to be mangled by perltidy.  It also adds trailing
>> commas to the last item in multi-line command arrays, which is common
>> perl style.

> +1 for this approach.

Indeed, this is much nicer if it's something perltidy knows about.

However, I know we have the same issue in many other places.
Anyone feel like running through all the TAP scripts?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: .ready and .done files considered harmful
Next
From: Andres Freund
Date:
Subject: Re: Proposal for Updating CRC32C with AVX-512 Algorithm.