Re: Quoting of psql \d output - Mailing list pgsql-patches

From Tom Lane
Subject Re: Quoting of psql \d output
Date
Msg-id 645.1072157250@sss.pgh.pa.us
Whole thread Raw
In response to Quoting of psql \d output  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Quoting of psql \d output  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> psql \d always double-quotes table names:
>           Table "public.xx"

Yeah, that has bugged me for a while, because it is in fact *wrong* ...
the above representation of a qualified name is incorrect.

> This patch uses pg_dump fmtId() to double-quote only when necessary.

Seems good, but I think your Makefile patch is a brick or two shy of
a load.  Don't you need something to make sure that parser/keywords.o
is up to date?

More generally, maybe we ought to think about moving fmtId() and perhaps
other parts of dumputils out of pg_dump and into some
more-easily-accessible library.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Quoting of psql \d output
Next
From: "Peter Eisentraut"
Date:
Subject: Re: Quoting of psql \d output