Re: [PING] fallocate() causes btrfs to never compress postgresql files - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PING] fallocate() causes btrfs to never compress postgresql files
Date
Msg-id 643576b4-4ffd-4ffd-bc3e-dee4a3ab1eed@dunslane.net
Whole thread Raw
In response to Re: [PING] fallocate() causes btrfs to never compress postgresql files  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PING] fallocate() causes btrfs to never compress postgresql files
List pgsql-hackers
On 2026-02-06 Fr 1:31 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 2026-02-06 Fr 10:11 AM, Tom Lane wrote:
>>> The message is complaining that sizeof(ConfigureNamesEnum) changed,
>>> which it did, but I don't see how that value would be visible to
>>> external modules.  So maybe a bug in libabigail?
>> I guess because of this in guc_tables.h:
>> extern PGDLLIMPORT struct config_generic ConfigureNames[];
> Evidently, but I don't see how that provides a sizeof() value to
> onlookers.  Just to be sure, I tried to compile a use of that,
> and got
>
> test.c:43:53: error: invalid application of ‘sizeof’ to incomplete type ‘struct config_generic[]’
>    elog(NOTICE, "sizeof(ConfigureNames) = %zu", sizeof(ConfigureNames));
>                                                       ^
>
> So if this isn't an outright bug, it's at least unhelpful behavior.
>

Fair enough. I agree it's not terribly helpful. In any case, maybe we 
need to look at my earlier suggestion of adding a suppression file.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Decoupling our alignment assumptions about int64 and double
Next
From: surya poondla
Date:
Subject: Re: log_min_messages per backend type