Re: Should contrib modules install .h files? - Mailing list pgsql-hackers

Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> Two questions arise:

> 1) include/server has a lot of files and subdirs, so using
>    include/server/$(MODULE)/ looks likely to be error-prone. So it
>    should be something like include/server/contrib/$(MODULE)/ or
>    include/server/extension/$(MODULE)/. Which one, or should it use
>    $(MODULEDIR) to choose between the two the way that DATA and DOCS do?
>    Or something else?

Might as well follow the MODULEDIR precedent (though I'm not wedded
to that if somebody has an argument for something else).

> 2) Specifying HEADERS_blah for some name "blah" that's not listed in
>    MODULES or MODULE_big should do what:
>   a) install into blah/ anyway
>   b) be ignored with a warning
>   c) be silently ignored
>   d) be an error

I'd definitely vote for "error".  Likewise if any .h file listed in
the macro doesn't exist.

            regards, tom lane