Re: Should we remove -Wdeclaration-after-statement? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Should we remove -Wdeclaration-after-statement?
Date
Msg-id 64156ca5-ed3c-4e78-bd99-fe513568bd44@eisentraut.org
Whole thread Raw
In response to Re: Should we remove -Wdeclaration-after-statement?  (Jelte Fennema-Nio <postgres@jeltef.nl>)
List pgsql-hackers
On 29.01.24 16:03, Jelte Fennema-Nio wrote:
> I feel like this is the type of change where there's not much
> discussion to be had. And the only way to resolve it is to use some
> voting to gauge community opinion.
> 
> So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
> +1 to indicate support against/for the change.
> 
> I'll start: +1
> 
> Attached is a patch that removes -Wdeclaration-after-statement in the
> codebase. This is mainly to be able to add it to the commitfest, to
> hopefully get a decent amount of responses.

-1, mostly for the various reasons explained by others.




pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Incorrect cost for MergeAppend
Next
From: Richard Guo
Date:
Subject: Re: Some revises in adding sorting path