Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain
Date
Msg-id 634373.1766440238@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> That revealed another problem: Mkvcbuild.pm didn't add -lpgport.  It
> looks out for the pattern PG_LIBS_INTERNAL = $(libpq_pgport), so
> that's an easy way to fix that -- is there a better way?  I couldn't
> figure out how to tell it that we need libpqport but not libpq.

AFAICT from looking at v16 Mkvcbuild.pm, PG_LIBS_INTERNAL = $(libpq_pgport)
will do exactly what you want because that only triggers it to add
libpgport and libpgcommon (cf. lines 1053ff).  I'm a little baffled
by that --- shouldn't it be pulling in libpq as well?  But let's let
sleeping dogs lie.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain
Next
From: Masahiko Sawada
Date:
Subject: Re: psql: Fix tab completion for VACUUM option values