Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
Date
Msg-id 631ce0a7-323f-4741-a76c-2cd6e1e8a6a7@eisentraut.org
Whole thread Raw
In response to [PATCH] Proposal: Improvements to PDF stylesheet and table column widths  (Noboru Saito <noborusai@gmail.com>)
Responses Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
List pgsql-hackers
On 08.05.25 09:18, Noboru Saito wrote:
> 3. **Replaced `text-indent` with `margin-left` for `func_signature` and
> `column_definition`**:
> - The previous `text-indent: -3.5em` only affected the first line, causing
> inconsistent formatting for multi-line code blocks. Changing this to
> `margin-left: 0em` ensures consistent alignment across all lines.

I think I found what this is meant to change, but it's not clear why one 
is better than the other.  I think you would need to provide some 
concrete examples with screenshots perhaps that people could look at.

> 4. **Introduced `shade.verbatim.style`**:
> - Added a shaded background for code blocks to improve visual distinction.
> This includes a border, padding, and a light gray background color
> (`#EFEFEF`).
> - Adjusted padding to reduce excessive spacing above code blocks.

I'm not a fan of this change.  The boxes break the flow of the text.

I think it's ok to put boxes and shading around elements that are not in 
the flow of the text, like the warning boxes, are perhaps tables or 
formal examples.  But not verbatim text that is part of the main text.




pgsql-hackers by date:

Previous
From: Fabrice Chapuis
Date:
Subject: Re: Issue with logical replication slot during switchover
Next
From: Peter Geoghegan
Date:
Subject: Re: index prefetching