Refactoring postgres_fdw code to rollback remote transaction - Mailing list pgsql-hackers

From Fujii Masao
Subject Refactoring postgres_fdw code to rollback remote transaction
Date
Msg-id 62fbb63a-d46c-fb47-a56d-f6be1909aa44@oss.nttdata.com
Whole thread Raw
Responses Re: Refactoring postgres_fdw code to rollback remote transaction  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers
Hi,

In postgres_fdw, pgfdw_xact_callback() and pgfdw_subxact_callback() do
almost the same thing to rollback remote toplevel- and sub-transaction.
But their such rollback logics are implemented separately and
in different way. Which would decrease the readability and maintainability,
I think. So how about making the common function so that those callback
functions can just use it? Patch attached.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Estimating HugePages Requirements?
Next
From: Zhihong Yu
Date:
Subject: Re: Refactoring postgres_fdw code to rollback remote transaction