Re: [PATCH] Fix vacuum_delay_point happening inside lock - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: [PATCH] Fix vacuum_delay_point happening inside lock
Date
Msg-id 623751C6-7521-4E17-9747-721930864A69@yandex-team.ru
Whole thread
Responses Re: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c
List pgsql-hackers

> On 4 Aug 2026, at 13:13, Neil Chen <carpenter.nail.cz@gmail.com> wrote:
>
>     Assert(InterruptHoldoffCount == 0);
>     Assert(CritSectionCount == 0);
>
> With assistance from OpenAI Codex (Sol), I tried this locally; it builds and
> passes the core regression tests. I have not benchmarked the performance
> tradeoff described above.

I think that asserts are a bit too much. I observed several other
non-interruptible cases of check for interrupts. But all other cases
that I found were called sometimes without LWlocks too.

Also, make check-world is completely different beast than make check.
I will take a lot more time, but also cover a lot more cases. I used
regression tests, isolation and some subset of other tests. With Sol,
perhaps, you can scan through logs of whole make check-world.


Best regards, Andrey Borodin.


Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: data_checksums + debug_discard_caches = crash
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: CREATE SUBSCRIPTION ... SERVER vs. pg_dump, etc.