Re: Race conditions in logical decoding - Mailing list pgsql-hackers

From Antonin Houska
Subject Re: Race conditions in logical decoding
Date
Msg-id 62335.1768897833@localhost
Whole thread Raw
In response to Race conditions in logical decoding  (Antonin Houska <ah@cybertec.at>)
Responses Re: Race conditions in logical decoding
Re: Race conditions in logical decoding
List pgsql-hackers
Antonin Houska <ah@cybertec.at> wrote:

> I'm not sure yet how to fix the problem. I tried to call XactLockTableWait()
> from SnapBuildAddCommittedTxn() (like it happens in SnapBuildWaitSnapshot()),
> but it made at least one regression test (subscription/t/010_truncate.pl)
> stuck - probably a deadlock. I can spend more time on it, but maybe someone
> can come up with a good idea sooner than me.

Attached here is what I consider a possible fix - simply wait for the CLOG
update before building a new snapshot.

Unfortunately I have no idea right now how to test it using the isolation
tester. With the fix, the additional waiting makes the current test
block. (And if a step is added that unblock the session, it will not reliably
catch failure to wait.)

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


Attachment

pgsql-hackers by date:

Previous
From: Daniil Davydov
Date:
Subject: Re: Fix comments for buf_id field of BufferDesc structure
Next
From: Heikki Linnakangas
Date:
Subject: Re: Remove more leftovers of AIX support