Re: "Bogus data in lock file" shouldn't be FATAL? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: "Bogus data in lock file" shouldn't be FATAL?
Date
Msg-id 6217.1281975173@sss.pgh.pa.us
Whole thread Raw
In response to Re: "Bogus data in lock file" shouldn't be FATAL?  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Tom Lane's message of lun ago 16 11:49:51 -0400 2010:
>> The bottom line here is that it's not clear to me whether changing this
>> would be a net reliability improvement or not.  Maybe better to leave
>> it alone.

> In that case, maybe consider fsync'ing it.

Hrm ... I had supposed we did fsync lockfiles, but a look at the code
shows not.  This seems like a clear oversight.  I think we should not
only add that, but back-patch it.  It seems entirely plausible that the
lack of an fsync is exactly what led to the original complaint.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Conflicted names of error conditions.
Next
From: Alvaro Herrera
Date:
Subject: Re: refactoring comment.c