> On 10 Nov 2025, at 13:18, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> Hmm, there's not much space for further explanations on that line. We could add a longer multi-line comment but I'd
ratherkeep it short and consistent with the other similar fields around it. I hope that readers who want more
informationwill find the SLRU_PAGES_PER_SEGMENT definition and the comments there.
Fair enough.
> I did consider renaming the field to 'slru_seg_size', to rhyme with 'relseg_size' and 'xlog_seg_size'. But then it
wouldn'tmatch the name of SLRU_PAGES_PER_SEGMENT anymore. We could rename SLRU_PAGES_PER_SEGMENT too, but I'm not sure
it'sworth the code churn, and IMO "pages per segment" is better than "segment size" anyway because it tells you what
theunit is.
Agreed, renaming would be a net negative overall I think.
--
Daniel Gustafsson
