On Wed, 2026-04-01 at 18:07 -0500, Andrew Jackson wrote:
> Attached is an updated patch.
Thank you, it applies and passes the regression tests.
>
> > Good, but you should append something to the "errorMessage", like
> > conninfo_add_defaults() does elsewhere.
>
> Added an error append in this patch. It has the impact of printing 2
> lines of errors on failure though: one from the newly appended message
> and one from ldapServiceLookup. Not sure if there are other examples
> of this behavior in libpq. Will look into this more tommorow.
Oh, I didn't look at that. If ldapServiceLookup() already appends a
meaningful error message, there is no need to add another one.
>
>
The documentation is better now.
> --- a/src/interfaces/libpq/fe-connect.c
> +++ b/src/interfaces/libpq/fe-connect.c
> #ifdef USE_LDAP
> - if (strncmp(line, "ldap", 4) == 0)
> + /*
> + * Is this a potential ldapurl or a ldapserviceurl parameter?
> + */
> + if (strncmp(line, "ldap:", 5) == 0)
> {
> int rc = ldapServiceLookup(line, options, errorMessage);
That change does not really belong to the patch, but is alright by me.
I'll mark the patch as "ready for committer".
Yours,
Laurenz Albe
