Re: pg_partition_tree crashes for a non-defined relation - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_partition_tree crashes for a non-defined relation
Date
Msg-id 6105.1544243612@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_partition_tree crashes for a non-defined relation  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pg_partition_tree crashes for a non-defined relation  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Dec 07, 2018 at 10:04:06AM +0900, Michael Paquier wrote:
>> I think that we should make the function return NULL if the relation
>> defined does not exist, as we usually do for system-facing functions.
>> It is also easier for the caller to know that the relation does not
>> exist instead of having a plpgsql try/catch wrapper or such.

> Are there any objections about fixing this issue?  I would rather fix it
> sonner than later.

Return NULL seems a reasonable behavior.

How about cases where the relation OID exists but it's the wrong
kind of relation?

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: extended query protcol violation?
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0