Re: [HACKERS] Zeroing damaged pages - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] Zeroing damaged pages
Date
Msg-id 6105.1141695538@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Zeroing damaged pages  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] Zeroing damaged pages  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:

> +     /* Even if zero_damaged_pages is true, we don't want autovacuum zeroing. */
> +     zero_damaged_pages = false;

This is completely incorrect; you need to set the variable via GUC, else
it will still be overridden from postgresql.conf if a SIGHUP arrives.
I believe this would work:

    SetConfigOption("zero_damaged_pages", "false",
            PGC_SUSET, PGC_S_SESSION);

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Backslashes in string literals
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Zeroing damaged pages