Re: Additional role attributes && superuser review - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Additional role attributes && superuser review
Date
Msg-id 6097.1425317992@sss.pgh.pa.us
Whole thread Raw
In response to Re: Additional role attributes && superuser review  (Stephen Frost <sfrost@snowman.net>)
Responses Re: Additional role attributes && superuser review
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> * Alvaro Herrera (alvherre@2ndquadrant.com) wrote:
>> If we were choosing those names nowadays, would we choose CREATEDB at
>> all in the first place?  I think we'd go for something more verbose,
>> probably CREATE_DATABASE.  (CREATEROLE is not as old as CREATEDB, but my
>> bet is that it was modelled after CREATEUSER without considering the
>> whole readability topic too much.)
>> 
>> Anyway it doesn't seem to me that consistency with lack of separators in
>> those very old names should be our guiding principle here.

> So you'd advocate EXCLUSIVE_BACKUP and NOEXCLUSIVE_BACKUP?  Or
> NO_EXCLUSIVE_BACKUP?  Or..?  If this was a green field, I think we might
> actually use spaces instead, but I'm really not sure we want to go
> through and redo everything that way at this point..  We'd end up
> breaking a lot of scripts that currently work today and I'm really not
> convinced it's better enough to justify that.

FWIW, I agree with Alvaro, and I'd go with e.g. NO_EXCLUSIVE_BACKUP.

I concur that multiple separate words would be a syntax mess, but I
see no reason not to use underscores instead.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Merge compact/non compact commits, make aborts dynamically sized
Next
From: Stephen Frost
Date:
Subject: Re: Additional role attributes && superuser review