Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Fix NULL checking in check_TSCurrentConfig() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()
Date
Msg-id 6073.1358739261@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Tree view 
Stephen Frost <sfrost@snowman.net> writes:
> * Xi Wang (xi.wang@gmail.com) wrote:
>> The correct NULL check should use `*newval'; `newval' must be non-null.

> Why isn't this using pstrdup()..?

The GUC API uses malloc, mainly because guc.c can't afford to lose
control on out-of-memory situations.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: dividing privileges for replication role.
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()