Re: Coverity Open Source Defect Scan of PostgreSQL - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Coverity Open Source Defect Scan of PostgreSQL
Date
Msg-id 6064.1141771158@sss.pgh.pa.us
Whole thread Raw
In response to Re: Coverity Open Source Defect Scan of PostgreSQL  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: Coverity Open Source Defect Scan of PostgreSQL  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-hackers
Martijn van Oosterhout <kleptog@svana.org> writes:
> #ifdef STATIC_ANALYSIS
> #define ereport(elevel, rest)  \
>         (errstart(elevel, __FILE__, __LINE__, PG_FUNCNAME_MACRO) ? \
>          (errfinish rest) : (void) 0), (elevel >= ERROR ? exit(0) : 0)
> #else
> /* Normal def */
> #endif

Hmm, neat idea ... though I wonder whether either gcc or Coverity's tool
is smart enough to draw the right conclusions from a conditional exit()
call ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Martijn van Oosterhout
Date:
Subject: Re: Coverity Open Source Defect Scan of PostgreSQL
Next
From: Tom Lane
Date:
Subject: Merge algorithms for large numbers of "tapes"