Re: seemingly useless #include recently added - Mailing list pgsql-hackers

From Tom Lane
Subject Re: seemingly useless #include recently added
Date
Msg-id 604013.1682392325@sss.pgh.pa.us
Whole thread Raw
In response to seemingly useless #include recently added  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: seemingly useless #include recently added  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> While working on a patch, I noticed that a rcent commit (d4e71df6d75)
> added an apparently unnecessary inclusion of guc.h in smgr.h.

Yes, that seems quite awful, and I also wonder why it changed fd.h.
Adding #include's to header files is generally not the first choice.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: seemingly useless #include recently added
Next
From: Thomas Munro
Date:
Subject: Re: seemingly useless #include recently added