Re: [PATCH] Provide rowcount for utility SELECTs - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [PATCH] Provide rowcount for utility SELECTs
Date
Msg-id 603c8f071002120934t3476e01evd4686ad2b343f640@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Provide rowcount for utility SELECTs  (Boszormenyi Zoltan <zb@cybertec.at>)
Responses Re: [PATCH] Provide rowcount for utility SELECTs
Re: [PATCH] Provide rowcount for utility SELECTs
List pgsql-hackers
On Fri, Feb 12, 2010 at 10:48 AM, Boszormenyi Zoltan <zb@cybertec.at> wrote:
> I added a small change to protocol.sgml for the
> "CommandComplete" message describing the change.
> Is it enough?

Ah, I didn't even see that that section needed to be updated.  Good
catch.  I'd suggest the following wording:

For a <command>SELECT</command> or <command>CREATE TABLE AS</command>
command, the tag is SELECT rows... [and the rest as you have it]

We should probably also retitle that section from "Retrieving Result
Information for Other Commands" to "Retrieving Other Result
Information" and adjust the text of the opening sentence similarly.

Also I think you need to update the docs for PQcmdtuples to mention
that it not works for SELECT and CTAS.

...Robert


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL
Next
From: Tom Lane
Date:
Subject: Re: review: More frame options in window functions