Re: Red-black tree for GIN - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Red-black tree for GIN
Date
Msg-id 603c8f071001240726p27d2ca1ds4dad0aa51588feef@mail.gmail.com
Whole thread Raw
In response to Re: Red-black tree for GIN  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: Red-black tree for GIN  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
2010/1/24 Teodor Sigaev <teodor@sigaev.ru>:
>> 3. This code could really use some more comments, and maybe some of
>> the variable names could be better chosen, too.  It's far from obvious
>> what is going on here.  I studied rbtrees in college and I still
>> remember more or less how they work, but, boy, this is hard to follow.
>>  The names of the iterator states are truly horrible, at least IMO.
>
> I changed names and slightly improve comments.

Would it be OK if I went through here and hacked on the comments and
sent this back to you?

...Robert


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: commit fests
Next
From: "Kevin Grittner"
Date:
Subject: Re: commit fests