Re: attoptions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: attoptions
Date
Msg-id 603c8f071001221004i24ffd1daweb1c508c570cc8e5@mail.gmail.com
Whole thread Raw
In response to Re: attoptions  (Alex Hunsaker <badalex@gmail.com>)
List pgsql-hackers
On Thu, Jan 21, 2010 at 10:24 AM, Alex Hunsaker <badalex@gmail.com> wrote:
> On Thu, Jan 21, 2010 at 07:30, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Thu, Jan 21, 2010 at 12:57 AM, Alex Hunsaker <badalex@gmail.com> wrote:
>>> Seems to me a comment about the above might be nice.  Something like
>>> /* Things after here are should always be default null */ in
>>> pg_attribute.h ?
>>
>> Well... that wouldn't actually be a correct summary, so no.  The point
>> is that variable-length fields are not used in tuple descriptors.
>> I'll add a comment about that.
>
> Yes that sounds much better, I was struggling to find the words.  What
> I was trying to express was something along the lines of you cant have
> a non null value after these because you cant statically initialize
> them in genbki.

Committed.   Thanks for the very thorough review.

...Robert


pgsql-hackers by date:

Previous
From: Leonardo F
Date:
Subject: Re: About "Our CLUSTER implementation is pessimal" patch
Next
From: Tom Lane
Date:
Subject: Re: About "Our CLUSTER implementation is pessimal" patch