Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting
Date
Msg-id 603c8f071001041942k551ec54chafb8d69022929c6e@mail.gmail.com
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting  (Greg Stark <gsstark@mit.edu>)
List pgsql-hackers
On Mon, Jan 4, 2010 at 9:34 PM, Tom Lane <tgl@postgresql.org> wrote:
> Log Message:
> -----------
> Remove too-smart-for-its-own-good optimization of not overwriting the output
> files when they haven't changed.  This confuses make because the build fails
> to update the file timestamps, and so it keeps on doing the action over again.

This doesn't seem like a good idea.  Not rebuilding the output files
also saves recompiling the things that depend on them.  For the BKI
files thast doesn't matter much, but for schemapg.h it might be
significant.  Certainly, if we move to generating more header files
this way, it WILL be significant.  If running the script is cheap (and
it should be), it's better to take that hit rather than recompiling a
whole mess of .c files unnecessarily.

...Robert


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Verifying variable names in pgbench
Next
From: Takahiro Itagaki
Date:
Subject: Re: Verifying variable names in pgbench