Re: Patch: Remove gcc dependency in definition of inline functions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Patch: Remove gcc dependency in definition of inline functions
Date
Msg-id 603c8f070912152142v1a10d2e5j5daee8d4accba2f0@mail.gmail.com
Whole thread Raw
In response to Re: Patch: Remove gcc dependency in definition of inline functions  (Kurt Harriman <harriman@acm.org>)
Responses Re: Patch: Remove gcc dependency in definition of inline functions
Re: Patch: Remove gcc dependency in definition of inline functions
List pgsql-hackers
On Tue, Dec 15, 2009 at 10:34 PM, Kurt Harriman <harriman@acm.org> wrote:
>> Your worry ii) can be ignored, managing to compile on such
>> compilers is already overachievement.
>
> I think so too.  With your opinion added to mine, do we constitute a
> consensus of the pg community?  Someone might object that a sample of
> two individuals is insufficiently representative of the whole, but
> away with the pedants: let us not quibble over trifles.

I haven't completely followed this thread, but I think there has been
some discussion of making changes to inline that would cause
regressions for people using old, crappy compilers, and I think we
should avoid doing that unless there is some compelling benefit.  I'm
not sure what that benefit would be - I don't think "cleaner code" is
enough.

...Robert


pgsql-hackers by date:

Previous
From: Kurt Harriman
Date:
Subject: Re: Patch: Remove gcc dependency in definition of inline functions
Next
From: KaiGai Kohei
Date:
Subject: [PATCH] Cleanup existing PG privileges - database, schema