Re: generic explain options v3 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: generic explain options v3
Date
Msg-id 603c8f070907211821i692101c8jaa33cbce11ad81f0@mail.gmail.com
Whole thread Raw
In response to Re: generic explain options v3  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: generic explain options v3
List pgsql-hackers
On Tue, Jul 21, 2009 at 7:47 PM, Tom Lane<tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> Here is an updated version of my "generic options for explain" patch.
>
> What is the rationale for essentially duplicating defGetBoolean()?

I just didn't realize we already had something along those lines.
Updated patch attached, to which I've also applied Andres Freund's
parser changes, suggested here:

http://archives.postgresql.org/pgsql-hackers/2009-07/msg01213.php

> Also, I'd suggest changing the ExplainStmt struct to have a list of
> DefElem options instead of hard-wiring the option set at that level.

What is the advantage of that?

...Robert

Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: revised hstore patch
Next
From: Tom Lane
Date:
Subject: Re: Modifying TOAST_TUPLE_THRESHOLD and TOAST_TUPLE_TARGET?