Re: Well done, Hackers - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Well done, Hackers
Date
Msg-id 603c8f070811011836o6e4f040ende0c25f9bed7100@mail.gmail.com
Whole thread Raw
In response to Re: Well done, Hackers  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Well done, Hackers  (Josh Berkus <josh@agliodbs.com>)
List pgsql-hackers
> Without review, how can we determine the true state of a patch? I would
> guess that you haven't done a review of all of them yourself to
> determine that.

No, I'm talking about the comments that were made when submitting the
patch.  A few people said things along the lines of "this isn't really
finished" or "this has major bugs".

> Your characterisation of other developers seems negative to me and I
> really do hope unfair. Nobody I know has submitted anything half-baked,
> but I haven't reviewed any patches yet. Review is about asking for help
> from your peers, not an admission of crap software. We're all seeking to
> learn more and be better, I hope.

Sorry.  I don't mean to be negative, and certainly not about the
developers.  I'm actually quite impressed by the number of people
submitting patches, and I'm really looking forward to some of the
proposed new features.  My point is just that about 10% of them sound
like they aren't actually done.

And as I said in my previous email, I don't even think that's the main issue.

> For myself, I've submitted a patch touching more than 60 files. Am I
> nervous I got something wrong? Damn right. Is there some horror lurking
> in there that I'm not saying, but frantically fixing now? No way. That's
> not the spirit.

I wasn't talking about your patches.  :-)

...Robert


pgsql-hackers by date:

Previous
From: "Vladimir Sitnikov"
Date:
Subject: Re: Windowing Function Patch Review -> Performance Comparison.
Next
From: "Robert Haas"
Date:
Subject: Re: Well done, Hackers