Re: pgsql: Improve error messages for bytea decoding failures. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Improve error messages for bytea decoding failures.
Date
Msg-id 6002.1404918895@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Improve error messages for bytea decoding failures.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: Improve error messages for bytea decoding failures.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
Robert Haas <rhaas@postgresql.org> writes:
> Improve error messages for bytea decoding failures.

Per style guide, errhints should be capitalized full sentences, ie

- errhint("input data is missing padding, truncated, or otherwise corrupted")));
+ errhint("Input data is missing padding, truncated, or otherwise corrupted.")));

Also, it's unwise to use %c on a value you aren't sure is an ASCII
character; that's likely to produce an invalidly-encoded error message,
which will *not* be an improvement of the user experience.

            regards, tom lane


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Improve error messages for bytea decoding failures.
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Improve error messages for bytea decoding failures.