Re: pgsql-server: Fix obviously-utterly-untested - Mailing list pgsql-committers

From Philip Warner
Subject Re: pgsql-server: Fix obviously-utterly-untested
Date
Msg-id 6.1.1.1.0.20040831142936.048100e0@203.8.195.10
Whole thread Raw
In response to pgsql-server: Fix obviously-utterly-untested noTocComments code.  (tgl@svr1.postgresql.org (Tom Lane))
Responses Re: pgsql-server: Fix obviously-utterly-untested  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-committers
At 05:44 AM 31/08/2004, Tom Lane wrote:
Fix obviously-utterly-untested noTocComments code.

It was extensively tested with a variety of DBs.

I *think* the problem was that the patch may have been against a too-old source (8.0b1), which still had _printTocHeader and _printTocData. eg. the code:

-       if
(AH->noTocComments)
-               return;
-

should have been in _printTocHeader, whereas it ended up in _printTocEntry.

Can this be easily avoided in the future? More context and/or just use latest CVS?


----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 03 5330 3172          |                 ___________ |
Http://www.rhyme.com.au          |                /           \|
                                 |    --________--
PGP key available upon request,  |  /
and from pgp.mit.edu:11371       |/

pgsql-committers by date:

Previous
From: pgsql@svr1.postgresql.org (PostgreSQL Daemon)
Date:
Subject: pgsql-server: tag configure beta2
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql-server: Fix obviously-utterly-untested