Re: Unexpected behavior when setting "idle_replication_slot_timeout" - Mailing list pgsql-bugs

From Fujii Masao
Subject Re: Unexpected behavior when setting "idle_replication_slot_timeout"
Date
Msg-id 5fddbcc5-0c05-493d-a3f0-1fe49ffe5600@oss.nttdata.com
Whole thread Raw
In response to Re: Unexpected behavior when setting "idle_replication_slot_timeout"  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: Unexpected behavior when setting "idle_replication_slot_timeout"
List pgsql-bugs

On 2025/07/10 14:51, Laurenz Albe wrote:
> On Thu, 2025-07-10 at 05:27 +0000, Hayato Kuroda (Fujitsu) wrote:
>>>> The "hybrid approach" saves the two seconds on system with injection points,
>>>> but cannot simplify the code.
>>>
>>> I feel that would be a needless complexity in the test.
>>
>> Yeah, it is the down side of the approach. If it do not have enough advantage, let's drop the idea.
> 
> Great, then I think that we have consensus.
> Let's change to seconds and leave the injectsion points and tests as they are.

+1


> I'd still like to see the documentation improved, like my patch tried to do.

Agreed.

I created this as a separate patch from the one that changes the unit,
since they serve different purposes. Both patches are attached.
I'm planning to commit them.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

Attachment

pgsql-bugs by date:

Previous
From: Jim Jones
Date:
Subject: Re: Starting a PostgreSQL server on a dynamic port (parameter port=0)
Next
From: Aleksander Alekseev
Date:
Subject: Re: PostgreSQL 18 beta1 - Segmentation fault on custom type casting